Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static Code Vulnerability: js/incomplete-URL-substring-sanitization #698

Open
JennaySDavis opened this issue Nov 13, 2024 · 2 comments
Open

Static Code Vulnerability: js/incomplete-URL-substring-sanitization #698

JennaySDavis opened this issue Nov 13, 2024 · 2 comments
Assignees
@johnbeallgsa
Labels
Sprint 44 Static Code Vulnerability

Comments

@JennaySDavis
Copy link
Contributor

Rule Name: js/incomplete-URL-substring-sanitization
Rule Description: gsa.gov' may be preceded by an arbitrary hostname.
Level: High
Location: (URI) training-front-end/src/plugins/uswds_links.js
Comments: Allowing all preceding hosts is intentional. This code labels a link as external if it is not on this site's domain or a subdomain.
@JennaySDavis
Copy link
Contributor Author

698 Acceptance Criteria

Pass/Fail Description
Pass Regression Testing of Training Website

Comments/Additional Notes
N/A

ADA Compliance (Automated scan via Chrome Lighthouse)

Criteria Score
Performance 98
Accessibility 100
Best Practices 100

Passed 12/03/2024 - JSD

@JennaySDavis JennaySDavis added Addition to Sprint The ticket is in addition to the planned sprint work and removed Addition to Sprint The ticket is in addition to the planned sprint work labels Dec 3, 2024
@johnbeallgsa
Copy link

Thanks for showing me at the Demo; I am moving to Done.

felder101 added a commit that referenced this issue Dec 5, 2024
@felder101
Production Release
374211b 
Sprint 44 Issues:
December 2024 Separation Report - Remove User #702
Static Code Vulnerability: js/incomplete-URL-substring-sanitization #698
@felder101 felder101 mentioned this issue Dec 5, 2024
Merged
felder101 added a commit that referenced this issue Dec 6, 2024
@felder101
Production Release (#708)
d3cb254 
Sprint 44 Issues:
December 2024 Separation Report - Remove User #702
Static Code Vulnerability: js/incomplete-URL-substring-sanitization #698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnbeallgsa johnbeallgsa

Labels
Sprint 44 Static Code Vulnerability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnbeallgsa @JennaySDavis