Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with design teams buttons #1568

Open
victoria-tighe-gsa opened this issue Nov 27, 2024 · 0 comments
Open

Inconsistency with design teams buttons #1568

victoria-tighe-gsa opened this issue Nov 27, 2024 · 0 comments

Comments

@victoria-tighe-gsa
Copy link

With all the circle buttons in sam styles. The classes used are
usa-button sds-button--circle + class for color scheme https://gsa.github.io/sam-styles/?path=/story/components-button-circle--default
While it being used in actions buttons sds-button sds-button--circular + class for color scheme

https://gsa.github.io/sam-design-system/?path=/story/components-actions-menu--configurable&args=size:;shadow:!false;label:;type:primary

Why is there inconsistency in the button pattern for circle buttons? This makes it so some of the color button schemes work for one but not the other.

Components Involved
Please list the common component(s) involved that you're experiencing an issue with

Expected Behavior
How you expect the listed component(s) to function

Actual Behavior
How the listed component(s) actually function

Your Environment
Angular Version: X.Y.Z
@gsa-sam packages version: X.Y.Z (Please list individually if all packages are not same version)

Ticket Number
Please provide your JIRA ticket number that is dependent on this fix. If there is none, please create
one to validate the issue once the fix has been released. DO NOT provide the url, please ONLY
provide the ticket number.
IAE-XYZ

Additional context
Screenshots / recordings, minimal reproduction on stackblitz, steps to reproduce, code snippets, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant