Horizontal filter reset #1563
Open
Horizontal filter reset #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayan-roshan
requested review from
davereed,
christyhermansen,
yerramshilpa and
cwolf10
as code owners
|
cwolf10
reviewed
Dec 12, 2024
| @@ -93,7 +93,8 @@ | |||
| </div> | |||
|
|
|||
| <div *ngIf="showReset" class="horizontal-reset margin-left-2 text-right"> | |||
| <sds-formly-reset [options]="options" [defaultModel]="{}" (resetClicked)="resetClicked.emit()"></sds-formly-reset> | |||
There was a problem hiding this comment.
This is changing what events are being emitted. resetClicked is no longer being emitted and filterChange is now being emitted when reset is clicked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the error caused when reset button was clicked and no horizontal filters were selected
resolves #1495
Description
when no formly forms were selected in the horiontal filters i cleared the model so it can clear the search input
Motivation and Context
Type of Change (Select One and Apply Github Label)
Screenshots (if appropriate):
Which browsers have you tested?
Checklist: