-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal Filter Reset Not Working #1495
Comments
Update with the new libs: The reset functionality is broken and selecting the reset does not reset the filter at all. The component also broke our test because the formControl seems disconnected. it('should clearFilters', () => { It failed because 'component.fileds[0].fieldGroup[0].formControl.' is undefined. |
Update with the new libs: These are currently in 55sam comp, /content/entity-information/resources/legacy-ct-code page When the CT Code is selected, the green box with that filter does not appear. The reset button is still not resetting the filters when selected. |
For more information here is another video recording going through the legacy-ct-codes page in COMP |
Components Involved
Horizontal Filter
Expected Behavior
Every time the reset button is selected on the horizontal filter, the filter emits an empty filter object.
Actual Behavior
When a reset of the filter occurs it only emits the empty filter on the first click.
Subsequent clicks of the reset button do not emit an empty filter.
Your Environment
Angular Version: 17.3.8
@gsa-sam/components: 17.0.5
@gsa-sam/icons: 1.0.0
@gsa-sam/layout: 17.0.1
@gsa-sam/layouts: 17.0.3
@gsa-sam/ngx-uswds: 17.0.1
@gsa-sam/ngx-uswds-icons: 17.0.0
@gsa-sam/sam-formly: 17.0.5
@gsa-sam/sam-material-extensions: 17.0.5
@gsa-sam/sam-styles: 3.0.18
@gsa-sam/shared: 17.0.3
Ticket Number
IAEMOD-28579
Additional context
Recording of the horizontal filter on 07/26/2024 from https://gsa.github.io/sam-design-system/?path=/story/formly-filter--horizontal
https://drive.google.com/file/d/1HO0K5Mdvx1ObKl9zt5S09Q3e_cZbL8FV/view
The text was updated successfully, but these errors were encountered: