Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formly Enhancements for JAWS and Icon Functionality #1445

Open
Sunset05 opened this issue Mar 19, 2024 · 11 comments
Open

Formly Enhancements for JAWS and Icon Functionality #1445

Sunset05 opened this issue Mar 19, 2024 · 11 comments
Assignees

Comments

@Sunset05
Copy link

Is your feature request related to a problem? Please describe.
I received a mock that has an optional address line 2 as blue text and when clicked an input field for address line two appears and the blue text will disappear. I am using a button with btnType: 'info'.

I am experiencing two main issues:

  1. I haven't been able to find a way to notify JAWS that a new field has opened and to focus it
  2. The mocks are calling for a plus icon to be placed to the left of the text and I haven't found a way to insert that into the text field

Describe the desired solution
The text has a plus icon to the left and when clicked JAWS is able to focus on the input field that is toggled into the form

Describe alternatives you've considered
I have tried to use DOM manipulation in the props.onClick($event), and the props.onKeyDown($event) to target the formfield and focus() it for JAWS and that has not consistently worked.

for the Icon I have seen implementations using field.props.addonLeft to add icon classes but it did not work and I haven't been able to insert angular icons.

Additional context
Formly button
image

Hidden field
image

design mock
image

@yerramshilpa yerramshilpa self-assigned this Jun 24, 2024
@brandydanner-gsa
Copy link

Just wanted to check if there are any updates on this? We will need the Street Address 2 component for the Entity Registration Modules MVP.

@yerramshilpa
Copy link
Collaborator

@brandydanner-gsa I am still working on it.

@brandydanner-gsa
Copy link

@davereed This is also needed for the Entity Registration Modules MVP since we need the Street Address 2 component for Taxpayer Information.

@yerramshilpa
Copy link
Collaborator

@brandydanner-gsa I am currently working on it.Will keep you updated

@brandydanner-gsa
Copy link

@yerramshilpa @davereed I had our tester use JAWS on the Storybook demo linked above, and he still has concerns because the focus is lost after pressing Enter on the "Street Address 2" link. Ideally the focus would go to the input field that appears.

@davereed
Copy link
Collaborator

Reopening this issue.

@davereed davereed reopened this Oct 28, 2024
@brandydanner-gsa
Copy link

@davereed Any update on if Design Team will be implementing a solution for the focus?

@yerramshilpa
Copy link
Collaborator

@brandydanner-gsa I am currently working on this item

@yerramshilpa
Copy link
Collaborator

yerramshilpa commented Nov 7, 2024

@brandydanner-gsa Here is the demo example of the address line 2 feature, it will be available in an upcoming release.

https://gsa.github.io/sam-design-system/pr-preview/pr-1487/?path=/story/formly-examples-address-form--address-form

@yerramshilpa
Copy link
Collaborator

This feature is implemented in @gsa-sam/[email protected] and @gsa-sam/[email protected] and here is the demo
https://gsa.github.io/sam-design-system/?path=/story/formly-examples-address-form--address-form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants