Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Preview Sites Do Not Include the Preview Site Hostnames #7709

Open
RileySeaburg opened this issue Jun 17, 2024 · 0 comments
Open

Bug: Preview Sites Do Not Include the Preview Site Hostnames #7709

RileySeaburg opened this issue Jun 17, 2024 · 0 comments
Assignees
Labels
Bug: broken links link errors/broken bug Things that are not working as they should be

Comments

@RileySeaburg
Copy link
Member

Describe the Bug
When using Federalist to build preview sites, the BASEURL environment variable does not include the preview site hostnames. This results in incomplete URLs, affecting og:url meta tags and social share links, which breaks indexing, sharing, and link generation functionalities on social media platforms.

Steps to Reproduce

  1. Set up a Hugo site with the provided config.yaml configuration.
  2. Deploy the Hugo site to Federalist.
  3. Access the preview site generated by Federalist.
  4. Inspect the generated HTML for the og:url meta tag and social share links.
  5. Notice that the URLs do not include the complete preview site hostname.

Expected Behavior
The BASEURL should dynamically include the correct hostname for the preview sites, ensuring that og:url meta tags and social share links are complete and functional.

Screenshots
Current output for og:url on preview sites:

<meta property="og:url" content="/preview/gsa/digitalgov.gov/nl-fix-og-url/" />

Expected output for og:url on preview sites:

<meta property="og:url" content="https://federalist-466b7d92-5da1-4208-974f-d61fd4348571.sites.pages.cloud.gov/preview/gsa/digitalgov.gov/nl-fix-og-url/" />

The hostname should be updated at each build.

@RileySeaburg RileySeaburg self-assigned this Jun 17, 2024
@RileySeaburg RileySeaburg added bug Things that are not working as they should be Bug: broken links link errors/broken labels Jun 17, 2024
@RileySeaburg RileySeaburg linked a pull request Jun 17, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: broken links link errors/broken bug Things that are not working as they should be
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant