Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More specific link previews on individual Fellow pages #184

Closed
chriskuang4 opened this issue Jul 19, 2022 · 19 comments · Fixed by #329
Closed

More specific link previews on individual Fellow pages #184

chriskuang4 opened this issue Jul 19, 2022 · 19 comments · Fixed by #329
Assignees
Labels
enhancement New feature or request fellow project Issues that Fellows can help support

Comments

@chriskuang4
Copy link
Contributor

chriskuang4 commented Jul 19, 2022

Fellows: Feel free to start working on these issues by assigning them to yourself. If you have any questions feel free to add it in the comments and tag @jaredbain and @Dahianna. Also always create a new branch and add Jared as reviewer.
Skills: Engineer and design

The current link previews when linking to a specific Fellow page are the generic USDC link preview. You can see this using a tool like Bannerbear or in DM-ing yourself the link in Slack and seeing the expanded preview.

I'd like to explore what it might look like if we used the Fellow's headshot as the photo preview, and had customized title and helper text that perhaps reflects the Fellow's bio, etc.

We have full scale images for each Fellow if we want to use those for the preview.

Current:
Screen Shot 2022-07-19 at 11 41 44 AM

@Dahianna
Copy link
Contributor

@jaredbain to look into options

@Dahianna Dahianna added the fellow project Issues that Fellows can help support label Sep 5, 2023
@mitchel-baker
Copy link

mitchel-baker commented Sep 5, 2023

This can be achieved with meta tags to add unique title, description, image, etc. but will need to look into how to setup for a Jekyll site.

Potential solution would be to add the following in digitalcorps.gsa.gov/_layouts/fellow.html for "og:title", "og:description", "og:image":

<meta property="og:image" content="{{ dynamic/path/to/fellow/headshot.jpg }}" />

@chriskuang4
Copy link
Contributor Author

thank you @mitchel-baker! That you're starting next week at CISA, @jaredbain will pick up with this.

@jaredbain
Copy link
Contributor

Code template created for the fellow bio pages social media preview images. Just waiting on the preview image cards with the IRL headshots

@chriskuang4
Copy link
Contributor Author

We need images 1200x628. @danielaaburtotc will work on this between now and early the week of 10/9 -- taking the headshots that we have to create the assets in the right size.

@chriskuang4
Copy link
Contributor Author

No progress yet (front office priorities), hoping to pick up later this week.

@Dahianna
Copy link
Contributor

@danielaaburtotc working on images

@daniela-aburto
Copy link

I sent the images to Jared via slack. We don't have these for the 2022 fellows, do we?

@Dahianna
Copy link
Contributor

Dahianna commented Oct 18, 2023 via email

@jaredbain
Copy link
Contributor

Missing some preview images for 2023 Fellows

  • Alyssa Bell
  • Drew Keller
  • Ryan Powers
  • Yuqing Zhou

@chriskuang4
Copy link
Contributor Author

chriskuang4 commented Oct 18, 2023 via email

@jaredbain
Copy link
Contributor

Another option can be create one similar to John Melton's preview image.

@Dahianna
Copy link
Contributor

Dahianna commented Nov 7, 2023

@danielaaburtotc will create cards similar to John's for the other Fellows that don't have headshots

@Dahianna
Copy link
Contributor

Daniela sent to Jared. @jared will update once Ruby is done

@Dahianna Dahianna assigned jaredbain and unassigned daniela-aburto Nov 29, 2023
@Dahianna
Copy link
Contributor

@danielaaburtotc to provide images for 2022 cohort as well

@Dahianna
Copy link
Contributor

@jaredbain has everything he needs, just waiting on Ruby update

@Dahianna
Copy link
Contributor

@danielaaburtotc working on last batch of images (5 Fellows) and then we can merge after Ruby update

@Dahianna
Copy link
Contributor

Dahianna commented Jan 2, 2024

@jaredbain
Copy link
Contributor

@Dahianna @chriskuang4 PR is ready for approval.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
@Dahianna Dahianna moved this to Done in the Backlog Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request fellow project Issues that Fellows can help support
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants