Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot Alert: Werkzeug safe_join not safe on Windows #371

Open
JennaySDavis opened this issue Oct 28, 2024 · 2 comments
Open

Dependabot Alert: Werkzeug safe_join not safe on Windows #371

JennaySDavis opened this issue Oct 28, 2024 · 2 comments

Comments

@JennaySDavis
Copy link
Contributor

JennaySDavis commented Oct 28, 2024

On Python < 3.11 on Windows, os.path.isabs() does not catch UNC paths like //server/share. Werkzeug's safe_join() relies on this check, and so can produce a path that is not safe, potentially allowing unintended access to data. Applications using Python >= 3.11, or not using Windows, are not vulnerable.

@JennaySDavis
Copy link
Contributor Author

JennaySDavis commented Nov 1, 2024

371 Acceptance Criteria

Pass/Fail Description
Pass Regression Testing on 889 Tool

Comments/Additional Notes
N/A

ADA Compliance (Automated scan via Chrome Lighthouse)

Criteria Score
Performance 96 *
Accessibility 100
Best Practices 100
*Performance score is related to a third-party Google Analytics cookie and cloud.gov = false positive

Passed 11/01/2024 - JSD

@johnbeallgsa
Copy link

Thanks for explaining during Demo. Moving to Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants