Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule ns-3 packets for incoming messages at time specified #46

Open
nightlark opened this issue Nov 23, 2021 · 1 comment
Open

Schedule ns-3 packets for incoming messages at time specified #46

nightlark opened this issue Nov 23, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@nightlark
Copy link
Member

Currently there seems to be a bug affecting the Static Source/Sink and Filter applications due to the callbacks for incoming messages from HELICS scheduling the ns-3 packets to be sent at the current ns-3 time instead of the time specified by HELICS for the message in the callback. The issue is that the callbacks are called before the HELICS request time function has given the granted time to ns-3 to advance its own simulation time.

The fix should be making the Send functions take the time given by the endpoint callback functions for messages, and schedule the ns-3 packet to be sent at time <incoming HELICS message time> - <ns3 simulation time>.

@nightlark nightlark added the bug Something isn't working label Nov 23, 2021
@laurmarinovici
Copy link
Collaborator

@nightlark Thanks for reporting this. Not sure if you were planning on looking into it soon. I've started to look at the code last week, and I think I have identified where the change needs to be done. However, I am not sure how fast I can tackle it as I am taking this week off. Let me know how you'd prefer so we do not duplicate effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants