Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEMSHOME removal #154

Open
Pshepp opened this issue Apr 4, 2023 · 4 comments
Open

GEMSHOME removal #154

Pshepp opened this issue Apr 4, 2023 · 4 comments
Assignees

Comments

@Pshepp
Copy link
Contributor

Pshepp commented Apr 4, 2023

To help make life easier, we should go ahead and begin removing our reliance or more so unnecessary constraint of utilizing the GEMSHOME variable.

I have begun using patterns that do not rely upon the env var, and began changing up the prepush tests so it does not require the environment variable.

@Pshepp
Copy link
Contributor Author

Pshepp commented Apr 5, 2023

Added the bug label because requiring the GEMSHOME env variable in so many places completely boogers up workflows and feels gross so its a bug. Plus we can make life oh so much easier and make the code more stronk. For example, I have removed a ton of the gemshome requirements from GMML to the point that I can just click "commit" on gitkraken and everything runs correctly

Also we even have c++ code dependent on environment variables, we should almost never do this it is mad ugly.

File that is dependent on an environment variable, idk if this file is in use. @gitoliver plz help after your back from vacation 👹 : src/MolecularModeling/Assembly/SugarIdentification/oligosaccharidedetection.cc

@Lachele
Copy link
Member

Lachele commented Apr 5, 2023

Assigning Dave. This is probably stale code. The use of getenv also wants to make an "Ontologies" directory inside of gems. I don't think this has been desirable behavior in a while. Can the use of GEMSHOME just go?

@gitoliver
Copy link
Contributor

gitoliver commented Apr 17, 2023

That code is still in use by glyfinder and Yao's glycomimetic tool. If you can edit it to not use $GEMSHOME, and still have the tests pass you should be fine. I would ask Yao to run tests separately as his glycomimetic tool isn't integrated.

@Pshepp
Copy link
Contributor Author

Pshepp commented Jun 7, 2023

This is mostly a note for myself so I keep tabs on this and know it is current. I want to make some of the replacement logic more robust and bullet proof but am wrapping some other things up rn. Going to also assign to myself so i can keep track of this more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants