Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with GAG parameters #116

Open
gitoliver opened this issue Nov 26, 2021 · 0 comments
Open

Issue with GAG parameters #116

gitoliver opened this issue Nov 26, 2021 · 0 comments
Assignees
Labels

Comments

@gitoliver
Copy link
Contributor

gitoliver commented Nov 26, 2021

The old gag builder (glycam.org/gag pre October 2021, currently legacy.glycam.org/gag) uses prep files that contain LIdopA in the different ring shapes (1C4, 4C1, 2SO). I reckon Arunima made them. The website code loads them in and modifies them depending on what's decorating the sugar. All fine, except that the charges used aren't the same as what we use for LIdopA in the regular carbohydrate builder. If you compare the prep files, they have different charges. I imagine what happened is that when they were developing the charges in this paper:
Extension and validation of the GLYCAM force field parameters for modeling glycosaminoglycans
They also calculated new charges for LIdopA (though it's not explicitly mentioned) and that's what Arunima used in the GAG builder. But no-one went back and changed the charges we use for LIdopA whenever the ring form isn't specified. So if you build a sugar on the GAG builder and specify the ring form for IdoA, you get different charges than if you didn't specify it, because different prep files get used. We won't be fixing this on legacy, but we do need to generate the prep files so the new website gives you up-to-date parameters. Oliver has copied the "undecorated" versions of the LIdopA prep files with different shapes into
gmml/dat/prep/GLYCAM_06j-1_GAGS.prep
so we have them somewhere that isn't legacy. But we also need to generate all the decorated versions.

@gitoliver gitoliver self-assigned this Nov 26, 2021
@gitoliver gitoliver added the bug label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant