Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different timestamp formats #103

Closed
ManuelKraft opened this issue Jan 20, 2023 · 6 comments · Fixed by #132
Closed

different timestamp formats #103

ManuelKraft opened this issue Jan 20, 2023 · 6 comments · Fixed by #132
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@ManuelKraft
Copy link

ManuelKraft commented Jan 20, 2023

Hi,

client = ohsome.OhsomeClient()
response = client.elements.geometry.post(time = "2008-01-01/2023-01-01/P1Y", ......)

---> you get a geodataframe with timestamps in the format "timestamp"

client = ohsome.OhsomeClient()
request = client.elements.count.groupByBoundary.post(time = "2008-01-01/2023-01-01/P1Y", .......)

---> you get a dataframe with timestamps in the format "timestamptz"

Would be nice if the format in 1) is also timestamptz.

Kind Regards,
Manuel

@SlowMo24
Copy link
Collaborator

Hi Manuel, thanks for reporting. we will have a look but feel free to open a pull request if this is a pressing problem for you.

@redfrexx redfrexx added the enhancement New feature or request label Nov 7, 2023
@redfrexx redfrexx added this to the 0.3.0 milestone Nov 8, 2023
@redfrexx redfrexx added the good first issue Good for newcomers label Nov 13, 2023
@SlowMo24 SlowMo24 added bug Something isn't working and removed enhancement New feature or request labels Nov 15, 2023
@SlowMo24
Copy link
Collaborator

we should always return what the API provides, preferrably without timezone. Therefore, check what the API returns for these two calls.

@SlowMo24
Copy link
Collaborator

ok looking at the docu helps: https://docs.ohsome.org/ohsome-api/v1/time.html

we should ALWAYS return timestamps without timezone because thats all the api privides

@redfrexx
Copy link
Member

redfrexx commented Nov 17, 2023

The ohsome API does not return a timestamp with timezone, but implicitly it is always UTC. So we could also return a timestamp with the UTC timezone so users know this right away?

@SlowMo24
Copy link
Collaborator

no timestamps with timezones are messi and harder to handle, rather not put a timezone and know that its UTC

@SlowMo24
Copy link
Collaborator

see also GIScience/ohsome-api#318

@SlowMo24 SlowMo24 removed the bug Something isn't working label Nov 21, 2023
@SlowMo24 SlowMo24 linked a pull request Nov 23, 2023 that will close this issue
SlowMo24 pushed a commit that referenced this issue Nov 29, 2023
because they are always in UTC anyway
closes #103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants