Add Trace/LogTrace and Critical/LogCritical

src/Arc4u.Standard.Diagnostics/Fluent/Common/CommonMessageLogger.cs

@@ -1,5 +1,5 @@
-using Microsoft.Extensions.Logging;
 using System;
+using Microsoft.Extensions.Logging;
 
 namespace Arc4u.Diagnostics
 {
@@ -56,11 +56,24 @@ public void LogWarning(string message, params object[] args)
             buildMessage.Log();
         }
 
+        public CommonLoggerProperties Critical(string message, params object[] args)
+        {
+            return AddEntry(LogLevel.Critical, message, null, args);
+        }
+
+        public void LogCritical(string message, params object[] args)
+        {
+            var buildMessage = AddEntry(LogLevel.Critical, message, null, args);
+            buildMessage.Log();
+        }
+
+        [Obsolete("This method is obsolete. Use Critical() instead")]
         public CommonLoggerProperties Fatal(string message, params object[] args)
         {
             return AddEntry(LogLevel.Critical, message, null, args);
         }
 
+        [Obsolete("This method is obsolete. Use LogCritical() instead")]
         public void LogFatal(string message, params object[] args)
         {
             var buildMessage = AddEntry(LogLevel.Critical, message, null, args);
@@ -89,9 +102,22 @@ public void LogException(Exception exception)
             Exception(exception).Log();
         }
 
-        internal CommonLoggerProperties System(string message, params object[] args)
+        internal CommonLoggerProperties Trace(string message, params object[] args)
         {
             return AddEntry(LogLevel.Trace, message, null, args);
         }
+
+        internal void LogTrace(string message, params object[] args)
+        {
+            var buildMessage = AddEntry(LogLevel.Trace, message, null, args);
+            buildMessage.Log();
+        }
+
+        internal CommonLoggerProperties System(string message, params object[] args)
+        {
+            var buildMessage = AddEntry(LogLevel.Trace, message, null, args);
+            buildMessage.Add("Arc4u", "Internal");  // to disambiguate between system logging inside Arc4u and user logging.
+            return buildMessage;
+        }
     }
 }

src/Arc4u.Standard.Diagnostics/Fluent/Monitor/MonitoringMessageLogger.cs

@@ -1,5 +1,5 @@
-using Microsoft.Extensions.Logging;
 using System;
+using Microsoft.Extensions.Logging;
 
 namespace Arc4u.Diagnostics
 {
@@ -35,6 +35,11 @@ public MonitoringLoggerProperties Information(string message)
             return AddEntry(LogLevel.Information, message);
         }
 
+        public MonitoringLoggerProperties Trace(string message)
+        {
+            return AddEntry(LogLevel.Trace, message);
+        }
+
         internal MonitoringLoggerProperties System(string message)
         {
             return AddEntry(LogLevel.Trace, message);

src/Arc4u.Standard.NServiceBus/Diagnostics/LoggerBridge.cs

@@ -1,6 +1,7 @@
-using Arc4u.Diagnostics;
-using NServiceBus.Logging;
 using System;
+using System.Globalization;
+using Arc4u.Diagnostics;
+using NServiceBus.Logging;
 using LogLevel = Microsoft.Extensions.Logging.LogLevel;
 
 namespace Arc4u.NServiceBus.Diagnostics
@@ -30,7 +31,7 @@ public void Debug(string message, Exception exception)
 
         public void DebugFormat(string format, params object[] args)
         {
-            LoggerBase.Technical.From<LoggerBridge>().Debug(String.Format(format, args)).Log();
+            LoggerBase.Technical.From<LoggerBridge>().Debug(String.Format(CultureInfo.InvariantCulture, format, args)).Log();
         }
 
         public void Error(string message)
@@ -46,23 +47,23 @@ public void Error(string message, Exception exception)
 
         public void ErrorFormat(string format, params object[] args)
         {
-            LoggerBase.Technical.From<LoggerBridge>().Error(String.Format(format, args)).Log();
+            LoggerBase.Technical.From<LoggerBridge>().Error(String.Format(CultureInfo.InvariantCulture, format, args)).Log();
         }
 
         public void Fatal(string message)
         {
-            LoggerBase.Technical.From<LoggerBridge>().Fatal(message).Log();
+            LoggerBase.Technical.From<LoggerBridge>().Critical(message).Log();
         }
 
         public void Fatal(string message, Exception exception)
         {
-            LoggerBase.Technical.From<LoggerBridge>().Fatal(message).Log();
+            LoggerBase.Technical.From<LoggerBridge>().Critical(message).Log();
             LoggerBase.Technical.From<LoggerBridge>().Exception(exception).Log();
         }
 
         public void FatalFormat(string format, params object[] args)
         {
-            LoggerBase.Technical.From<LoggerBridge>().Fatal(String.Format(format, args)).Log();
+            LoggerBase.Technical.From<LoggerBridge>().Critical(String.Format(CultureInfo.InvariantCulture, format, args)).Log();
         }
 
         public void Info(string message)
@@ -78,7 +79,7 @@ public void Info(string message, Exception exception)
 
         public void InfoFormat(string format, params object[] args)
         {
-            LoggerBase.Technical.From<LoggerBridge>().Information(String.Format(format, args)).Log();
+            LoggerBase.Technical.From<LoggerBridge>().Information(String.Format(CultureInfo.InvariantCulture, format, args)).Log();
         }
 
         public void Warn(string message)
@@ -94,7 +95,7 @@ public void Warn(string message, Exception exception)
 
         public void WarnFormat(string format, params object[] args)
         {
-            LoggerBase.Technical.From<LoggerBridge>().Warning(String.Format(format, args)).Log();
+            LoggerBase.Technical.From<LoggerBridge>().Warning(String.Format(CultureInfo.InvariantCulture, format, args)).Log();
         }
     }
 }

src/Arc4u.Standard.UnitTest/Logging/SerilogTests.cs

@@ -1,14 +1,14 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
 using Arc4u.Diagnostics;
 using Arc4u.Diagnostics.Serilog;
 using Arc4u.UnitTest.Infrastructure;
 using Microsoft.Extensions.Logging;
 using Serilog;
 using Serilog.Core;
 using Serilog.Events;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading.Tasks;
 using Xunit;
 
 namespace Arc4u.UnitTest.Logging;
@@ -37,7 +37,7 @@ public async Task LoggerArgumentTest()
                 logger.Technical().LogInformation("Information {Code}", 101);
                 logger.Technical().LogWarning("Warning {Code}", 102);
                 logger.Technical().LogError("Error {Code}", 103);
-                logger.Technical().LogFatal("Fatal {Code}", 104);
+                logger.Technical().LogCritical("Fatal {Code}", 104);
                 logger.Technical().LogException(new DivideByZeroException("Cannot divide by zero"));
 
                 await Task.Delay(1000);
@@ -68,7 +68,7 @@ public async Task LoggerTechnicalTest()
                 logger.Technical().Information("Information").Add("Code", "101").Log();
                 logger.Technical().Warning("Warning").Add("Code", "102").Log();
                 logger.Technical().Error("Error").Add("Code", "103").Log();
-                logger.Technical().Fatal("Fatal").Add("Code", "104").Log();
+                logger.Technical().Critical("Fatal").Add("Code", "104").Log();
                 logger.Technical().Exception(new DivideByZeroException("Cannot divide by zero")).Log();
                 logger.Monitoring().Debug("Memory").AddMemoryUsage().Log();
 

src/Arc4u.Standard/ServiceModel/Messages.cs

@@ -91,7 +91,7 @@ public void LogAll<T>(ILogger<T> logger, [CallerMemberName] string methodName =
                         property = categoryLogger.Error(lm.Text);
                         break;
                     case MessageType.Critical:
-                        property = categoryLogger.Fatal(lm.Text);
+                        property = categoryLogger.Critical(lm.Text);
                         break;
                     default:
                         property = categoryLogger.Debug(lm.Text);