-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check VerticalDimSpec based on name #3054
Labels
Comments
How would option (2) work? At the point one is examining the info object the dim spec object would generally not be available. And if it was available, there is no reason to use the info object. |
I also don't understand this sentence:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A
VerticalDimSpec
value is stored as a string in theESMF_Info
object in aESMF_Field
object. To check theVerticalDimSpec
value of anESMF_Field
requires a string match to a string literal. The string literal can be stored in a parameter so that multiple string literals are created for the sameVerticalDimSpec
, but then matching requires knowing the parameter name. There is no guarantee that the parameter name or string literal match the name of the relevantVerticalDimSpec
. This seems fragile.Two options:
ESMF_Info
for the VerticalDimSpec objects, and the parameters used for the creation would be public for the sake of comparison. This still requires that the parameter names be known, but it does protect against changes in the string in theESMF_Info
object.VerticalDimSpec
.The text was updated successfully, but these errors were encountered: