Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in generating new usernames #618

Open
hussamnasir opened this issue Mar 18, 2020 · 1 comment
Open

Bug in generating new usernames #618

hussamnasir opened this issue Mar 18, 2020 · 1 comment

Comments

@hussamnasir
Copy link
Contributor

username = "geni1"

In cases where email address do not have any alphabets in then to use in the genration of a geni username, this variable statically assigned "geni1" as a prefix.
Later down in the code line 114, the for loop counts to a max of 99 and also imposing a restriction that the len(username) is within 6 characters. Well we hit the limit of "geni199" today after which new users were not being created and GENI Portal/CH responding with errors. We need a better way of generating the username in such cases. For now my patch just replaces "geni1" assignment to "geni2" which is good for another 99 more such cases. Quick and dirty. This has been patched on the production server and a code patch here will follow soon.

@ahelsing
Copy link
Member

My apologies - that sounds like my code.

My memory is that because the username is combined with the CH name et al, that full protogeni slice name length limits were a problem, but I could be wrong. (Was it slice name? Something else?)
What are the normal GENI username length limits? Also 6?
Could we replace that 1 or 2, as well as the following 2 characters with and give ourselves 36^3 usernames?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants