Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SliceAuthority uses eval, should use getattr instead #475

Open
tcmitchell opened this issue Apr 5, 2016 · 1 comment
Open

SliceAuthority uses eval, should use getattr instead #475

tcmitchell opened this issue Apr 5, 2016 · 1 comment
Labels
bug

Comments

@tcmitchell
Copy link
Member

There are a number of calls to eval() in SAv1PersistentImplementation.modify_membership that could and should be replaced by getattr(). Using getattr() would be safer and faster.
@tcmitchell tcmitchell added the bug label Apr 5, 2016
@tcmitchell
Copy link
Member Author

There are a few other calls to eval elsewhere that should be looked at as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tcmitchell