Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] 나의 스터디 페이지 모달 구현 #39
[Feature] 나의 스터디 페이지 모달 구현 #39
Changes from 14 commits
c5f8156
33e2a3b
f488442
794101d
c69b64f
920864d
a2939bf
be69e07
c11492d
b4f098b
cd88bb6
e598f96
4167b3a
5faca05
5fbe708
00da8dc
639a53b
5c12da0
7ea2897
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P4;
출결번호가 최대 4글자까지니까
maxLength
props 추가하는게 어때용!?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추가해봤는데 기존 와우 디자인 시스템에 있던 maxLength 관련 디자인이 있어가지고... 피그마상 디자인이랑 동일하게 구현하려면 못 쓸 거 같아요..
이 PR에서 api 연결하면서 validation도 같이 진행 중이에요!
4글자 숫자로 이루어진 문자열인지 validation하도록 해놔서 괜찮을 거 같아요~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5;
next/link
의<Link>
로 감싸는 것이 아닌Button
컴포넌트를 확장시켜 쓰신건 뎁스를 줄이려는 의도가 맞을까요? 서버컴포넌트에서의 활용을 생각하면<Link>
가 더 적합하다고 생각합니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 일단 해당 컴포넌트를 구현한 이유가 두 가지입니다.
위 구현체에서 Button 컴포넌트 대신 Link 컴포넌트를 사용하게 되면 디자인 부분을 다시 다 구현해야 한다는 번거로움이 있어 현재로서는 이 방식이 최선이라고 생각했습니다!