Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build from source on ARM MacOS #78

Open
fgindraud opened this issue May 21, 2024 · 1 comment
Open

Fails to build from source on ARM MacOS #78

fgindraud opened this issue May 21, 2024 · 1 comment

Comments

@fgindraud
Copy link

While trying to help a user to build kissplice (which depends on bcalm) on an ARM Mac, I encountered two build issues.
I managed to track them down and fix them using github actions CI, as I do not have access to any ARM Mac myself.

The first issue is a missing #include inside the hdf5 copy within gatb-core. This compiles fine on Linux but failed for newer ARM MacOS. The fix used for my tests is available at fgindraud/gatb-core@4dffb1a. I can create a pull request for it if you want.

The second issue is the same as the one fixed by GATB/gatb-core@dc9264e, but this has not been propagated to bcalm yet (gatb-core submodule points to an earlier commit).

Due to both problems being in gatb-core, the problems can be fixed by adding the first fix to gatb-core, then update the submodule within bcalm to get both fixes. I cannot provide a pull request directly for bcalm as the new commit must first exist in gatb-core to be able to update the submodule.

fgindraud added a commit to fgindraud/bcalm that referenced this issue May 21, 2024
See GATB#78

bcalm failed to build on ARM MacOS due to 2 bugs :
- a missing #include inside the old vendored hdf5 inside gatb-core,
  which fails to build only on recent macs
- a cmake error in gatb-core which has been fixed but not made available
  to bcalm

Bumping the gatb-core version to include both fix commits solves the
issue.
@fgindraud
Copy link
Author

I found a way to make the pull requests in both gatb-core and bcalm that should work with submodules, as long as commit ids are not rewritten. The PR in bcalm requires the one in gatb-core first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant