New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinction between Human and Player ids in DeckView #296

Open

hopshackle opened this issue Oct 7, 2024 · 0 comments

Collaborator

hopshackle commented Oct 7, 2024

The first argument in DeckView is 'player'...but actually this should be the 'humanPlayer', not the player whose Deck it is.

Some improvements in the code documentation and naming woudl help here (and possibly some refactoring to reduce the risk of easy misunderstandings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment