Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics indexing efficiency #294

Open
hopshackle opened this issue Sep 24, 2024 · 0 comments
Open

Metrics indexing efficiency #294

hopshackle opened this issue Sep 24, 2024 · 0 comments
Assignees

Comments

@hopshackle
Copy link
Collaborator

MetricsGameListener.eventToIndexingColumn() now applies Tick as the indexing column for Turn or Tick based metrics, but Round for Round ones.
This was recently fixed from using Turn as the indexing column for Turn metrics - this caused a problem because Turn numbers are not unique as we may have Round 1 Turn 2, Round 2 Turn 2, Round 3 Turn 2 and so on. If Turn is used as the indexing column the result is that only the data from the last Round is recorded. (Hence the fix to use the safely unique Tick for indexing...this has no impact on the final result).

A possibility this raises is that this method could be removed, and we could always index on Tick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants