Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing disparity with Facebook OAuth #87

Open
glebec opened this issue Oct 3, 2016 · 0 comments
Open

Confusing disparity with Facebook OAuth #87

glebec opened this issue Oct 3, 2016 · 0 comments

Comments

@glebec
Copy link
Member

glebec commented Oct 3, 2016

Facebook uses a clientId in the strategy, but an APP_ID in the production environment variable. See https://github.com/FullstackAcademy/fsg/blob/master/generated/server/env/production.js#L18. While students should notice the difference and put the right vars in Heroku, it is pretty easy to overlook this as it is similar but not identical to the Google variable names.

Not sure why it is coded in as APP_ID — is it to match some Facebook dev tool verbiage? An oversight? Worth looking into to see if it wouldn't be less confusing standardized to CLIENT_ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant