Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Do not merge): Refactor fuel-core to use version of StorageRead::read with offset #2438

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

acerone85
Copy link
Contributor

Linked Issues/PRs

Related to FuelLabs/fuel-vm#681

Description

In order to load contracts from a given offset efficiently, we have changed the interface of StorageRead::read to accept a n offset in input (see FuelLabs/fuel-vm#863). This PR refactors the fuel-core repo to make use of the new StorageRead trait.

Do not merge

we should first wait for the changes to StorageRead to be released in fuel-vm, after which we can update the dependencies in this PR

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@acerone85
Copy link
Contributor Author

I find it suspicious that I never had to hardcode the offset value to 0 in this PR. Is StorageRead::read used at all in fuel-core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant