Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The delete-selection property on sp-[backward-]delete-char is broken with strict mode #1196

Open
Fuco1 opened this issue Mar 25, 2024 · 0 comments
Labels

Comments

@Fuco1
Copy link
Owner

Fuco1 commented Mar 25, 2024

Normally we place 'supersede but if strict mode is activated anywhere, it will get replaced with a custom smartparens check. However, the symbol property is global so it will now start working also in non-strict buffers. Further, if any strict buffer is turned non-strict, we reset the property which will then break all the strict buffers.

The solution is to always have the same custom smartparens check which will internally check strict mode status and decide based on that what to do.

@github-project-automation github-project-automation bot moved this to To triage in Triage Mar 25, 2024
@Fuco1 Fuco1 added the bug label Mar 25, 2024
@Fuco1 Fuco1 moved this from To triage to Ready in Triage Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready
Development

No branches or pull requests

1 participant