-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
org-mode: code marker should prevent nested pairs #1031
Comments
Thanks, this is a good suggestion. I added it to the default org config. |
The fix seems to cause massive input lag in a large Org file I have. I don't have minimal reproduction case yet, but there seems to be some interaction with single-quotes used as apostrophes in prose. It's not as simple as every such quote slowing down or speeding up text entry, but if I position my cursor after a certain quote near the end of the file, input is slow before said quote and normal afterwards. Calling I may be doing something or have some garbage in the file to cause the pathological behavior, but since rolling back the single commit fixed things I'm dropping this note in under-debugged form. |
That is very well possible. I will try to add an optimization which is going to be usefull in general to limit "string" pairs to the current subtree, because they can't span out of a tree in org mode anyhow. Might also want to stop the search on block boundaries and fixed width (line prefixed with This is not exactly cause of your issue, but I believe it will fix it and make everything faster as well. I'll ping you when I have a fix if you would be willing to test it :) I will track this in a new issue #1192 |
Expected behavior
~0200::/|~
should stay how it is.Actual behavior
~0200::/|/~
, i.e. a closing/
is added, which doesn't make sense in org-mode, as it's not possible to italicize text within~code markers~
.Steps to reproduce the problem
Backtraces if necessary (
M-x toggle-debug-on-error
)Environment & version information
smartparens
version:major-mode
:org-mode
M-x emacs-version
): GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.10)The text was updated successfully, but these errors were encountered: