Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MS/TP unit tests #18

Open
WhittlesJr opened this issue May 10, 2018 · 5 comments
Open

Add MS/TP unit tests #18

WhittlesJr opened this issue May 10, 2018 · 5 comments

Comments

@WhittlesJr
Copy link
Contributor

Sorry I still haven't gotten to this...

@WhittlesJr
Copy link
Contributor Author

So, I think what you really want is probably just the remote_device tests but with init-local-test-devices replaced with MSTP devices. Or do you think more is needed also?

@Frozenlock
Copy link
Owner

It might be enough.
See it this way : the test(s) will protect you against my savage modifications that are made using only the BACnet/IP side. 😉

@WhittlesJr
Copy link
Contributor Author

Hahaha understood.

@Frozenlock
Copy link
Owner

Any news on this? Or are tests not necessary?

@WhittlesJr
Copy link
Contributor Author

I'm really sorry... when I took a look to see what would need to be done, I realized that the only thing that would need to change given your current tests would be a different version of bacure.test.remote-device/init-local-test-devices!. The read-properties and basic-read-properties tests would be exactly the same.

And I'm not sure how to do that cleanly with clojure.test... I know what I would do with Midje, but does clojure.test give you the ability to iterate the same test over different options? At the time that I investigated, it seemed like it didn't.

You would also need to hook up two serial ports together on the machine running the tests, unless there's some clever way to fake that out with shell commands or something? Perhaps the serial socket could be overridden by a pure software one? I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants