Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review templates not being generated in copr #41

Open
juhp opened this issue Mar 4, 2024 · 3 comments
Open

review templates not being generated in copr #41

juhp opened this issue Mar 4, 2024 · 3 comments

Comments

@juhp
Copy link

juhp commented Mar 4, 2024

eg

$ curl -I https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260853-ghc-language-c99-util/fedora-rawhide-x86_64/07099420-ghc-language-c99-util/fedora-review/review.txt
HTTP/2 200 
content-type: text/plain
content-length: 0
etag: "1963244301"
last-modified: Sun, 03 Mar 2024 18:45:43 GMT
:

or is this some kind of caching/cloudfront issue?

As I see it this has actually been happening for some weeks now perhaps?
So it is a little disconcerting that it is still happening? Though I know it is not an official service. :-) 🙏

@juhp juhp changed the title review templates not being generated review templates not being generated in copr Mar 4, 2024
@FrostyX
Copy link
Owner

FrostyX commented Mar 4, 2024

Thank you for the report @juhp.

So it is a little disconcerting that it is still happening/unnoticed?

Don't worry, it wasn't unnoticed. It wasn't easy to investigate and fix :-/.

We had reports across all involved upstreams

The bug is in the fedora-review tool, Fedora Review Service and Copr are innocent. I am proposing the fix here

https://pagure.io/FedoraReview/pull-request/513

@michel-slm promised to review the changes and do a new release this week if it works well.

But I agree with you, it is a bad look (for the service) that it doesn't work and wasn't fixed yet.

@juhp
Copy link
Author

juhp commented Mar 4, 2024

Okay sorry, thank you for the detailed explanation - appreciate all the efforts and your dedication

@FrostyX
Copy link
Owner

FrostyX commented Mar 4, 2024

Okay sorry

Np, I am glad you reported the issue.
I will keep it open, so we have some ticket for Fedora Review Service as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants