Accept arguments in the review body

[farchord]

One feature that would be awesome in the Fedora review service is the option to add arguments. For example:

[side-tag: f40-build-side-78580] would build against said side tag (Useful for when we are updating a software stack that isn't pushed to rawhide yet and will fail to build otherwise)

[enablerepo: local] (I don't know if this is already default behavior) Enables building against the bodhi local repo (Before a compose has occured)

There may be others that would help, those are just what I've seen could help me.

Said arguments would be taken from comment 0, and could get updated as new comments get added.

[Conan-Kudo]

This service should probably always use enablerepo: local, but it would be very nice to have a way to tell it to load a side-tag in too.

[FrostyX]

Thank you for the RFE @farchord,

[enablerepo: local] (I don't know if this is already default behavior) Enables building against the bodhi local repo (Before a compose has occurred)

I agree with @Conan-Kudo, this should probably be done always. Can anyone see any downside of doing this?
Fedora Review Service builds the packages in Copr, so I need to know the full baseurl for the local repository. I guess that shouldn't be a blocker right?

[side-tag: f40-build-side-78580] would build against said side tag (Useful for when we are updating a software stack that isn't pushed to rawhide yet and will fail to build otherwise)

Please forgive my ignorance here, I haven't use sidetags before. The RFE should be useful for a software stack where multiple components depend on each other and all packages are in separate package reviews? I.e. the underlying dependencies are not fedora-review+ yet? I don't know how to understand the "that isn't pushed to rawhide yet".

[Conan-Kudo]

Side-tags are when stacks of things are being built before being merged into the main tag. This is useful for large stack upgrades (like KDE Plasma) and often times it winds up being that new packages are mixed in with upgraded packages. This case is not currently handled by the review service properly.

[Conan-Kudo]

I agree with @Conan-Kudo, this should probably be done always. Can anyone see any downside of doing this?
Fedora Review Service builds the packages in Copr, so I need to know the full baseurl for the local repository. I guess that shouldn't be a blocker right?

This is already in the mock configs, so you would just need to expose that and turn it on.

[farchord]

The way we build in a side tag is we generate a mock config with

´´´
koji mock-config —target TARGETID —arch x86_64
´´´

In the build service though, not 100% sure myself how that would work on copr.

[Conan-Kudo]

There's a URL formula for the underlying repositories Koji creates with side-tags, so the fedora-review-service can just use that formula to generate the URL for additional repositories.