Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config function should allow for more options #2

Open
freshteapot opened this issue Jan 23, 2014 · 1 comment
Open

Config function should allow for more options #2

freshteapot opened this issue Jan 23, 2014 · 1 comment

Comments

@freshteapot
Copy link

Currently our config function uses a very particular object mapping.

Would it be better to assume the object coming in is the "elasticsearch" friendly object and then we map it to the desired config settings or use defaults that we want to see used.

I got to this because I wanted to make "client" close. To achieve this I manually added the property "maxKeepAliveRequests".

    client = new elasticsearch.Client({
        host: config.db.url,
        maxKeepAliveRequests: 1
    });
@plumpNation
Copy link
Contributor

taken from the changelog (item 21)
http://www.srcmap.org/proj_src/elasticsearch/elasticsearch-js/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants