Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Array page in DSA section #42

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Updated Array page in DSA section #42

merged 3 commits into from
Oct 4, 2023

Conversation

ankit1296
Copy link
Contributor

@ankit1296 ankit1296 commented Oct 1, 2023 •
edited
Loading

Changes proposed

  • DSA option in sidebar

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

  • Content of video

image

  • Learn and Assignment Tabs

image

  • Learn tab content (video and code snippets)

image

  • Assignment tab content (questions)

image

Note to reviewers

@ManishBisht777 ManishBisht777 added the Hacktoberfest Good issues for Hacktoberfest participants label Oct 1, 2023
@Vishal-raj-1 Vishal-raj-1 removed the Hacktoberfest Good issues for Hacktoberfest participants label Oct 1, 2023
@Vishal-raj-1
Copy link
Member

Hey @ankit1296 just wait for 1 or 2 day. @sujitmemane is adding structure of DSA in JavaScript Batch. Then I will merge this PR.

@sujitmemane
Copy link
Member

@ankit1296

Check Issue No #101

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 6:31am

@Vishal-raj-1
Copy link
Member

@ankit1296 share the screenshot too once done

@ankit1296 ankit1296 changed the title Added DSA option in sidebar and added page for array's video Update Array page in DSA section Oct 3, 2023
@ankit1296 ankit1296 changed the title Update Array page in DSA section Updated Array page in DSA section Oct 3, 2023
@ankit1296
Copy link
Contributor Author

@Vishal-raj-1 Updated PR with Array content and updated screenshots and PR name. can you please check.

@ankit1296
Copy link
Contributor Author

@Vishal-raj-1 can you please check this

Vishal-raj-1
Vishal-raj-1 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@Vishal-raj-1 Vishal-raj-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@Vishal-raj-1 Vishal-raj-1 merged commit 09e7efe into FrontendFreaks:master Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vishal-raj-1 Vishal-raj-1 Vishal-raj-1 approved these changes

Assignees

@ankit1296 ankit1296

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankit1296 @Vishal-raj-1 @sujitmemane @ManishBisht777