Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fundamentals.mdx #204

Merged

Conversation

SanskritiGupta05
Copy link
Contributor

Fixes Issue #144

Changes proposed

Added a notes tab in the Build > ReactJS > Fundamentals

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

Note to reviewers

I'm encountering 3 errors continuously, although the content is showing up on the website as intended. Please review it.

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 6:04am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request and welcome to our community! We will be getting back to you soon . Your patience will be greatly appreciated! Thanks! 🥳

@Vishal-raj-1
Copy link
Member

Hey @SanskritiGupta05, If you read deployment details. It clearly says there is a problem in content layer. Read Complete message here👇🏻
image

Also, It mentions that you miss closing tag of TabsContent i.e, </TabsContent>.

There are 7 TabsContent, But it should be 6. It means you add extra TabsContent for Notes. We don't need TabsContent for Notes.

Solution?

  • Copy all content from notes tab, and paste in learn tab like other files.
  • fix TabsContent misMatch

@SanskritiGupta05
Copy link
Contributor Author

Okay, I'll get onto it! 🙌🏻

@SanskritiGupta05
Copy link
Contributor Author

SanskritiGupta05 commented Oct 15, 2023

Hi @Vishal-raj-1 all checks have been passed. please review and merge 😄

@Vishal-raj-1 Vishal-raj-1 merged commit c9c5325 into FrontendFreaks:master Oct 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants