Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search page updated in dsa folder #146

Merged
merged 2 commits into from
Oct 6, 2023
Merged

search page updated in dsa folder #146

merged 2 commits into from
Oct 6, 2023

Conversation

nsundriyal62
Copy link
Contributor

@nsundriyal62 nsundriyal62 commented Oct 5, 2023

Fixes Issue

Closes #114
Closes #112

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

s7
s8

Note to reviewers

in first screeenshot there is not callout statement because that it old screenshot
i updated it after that

you can crooss check the code for verify

line no-36

We hope that you found the tutorial video helpful in understanding the basic concepts of search in javascript, You can refer this notes 📝 for quick revision.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 11:42am

Copy link
Member

@Vishal-raj-1 Vishal-raj-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix these two basic changes


## 📺 Watch Now
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add Video Player and pass the link, check HTML page for reference

@@ -1,9 +1,170 @@
---
title: Search
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Title to Linear & Binary Search

Copy link
Contributor Author

@nsundriyal62 nsundriyal62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes are updated sir
:)

@Vishal-raj-1 Vishal-raj-1 merged commit af1da55 into FrontendFreaks:master Oct 6, 2023
2 checks passed
@nsundriyal62 nsundriyal62 deleted the search_dsa branch October 6, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants