Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs nav option seen on all pages now #125

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

Huzaifa785
Copy link
Contributor

@Huzaifa785 Huzaifa785 commented Oct 4, 2023

Fixes Issue

Fixed #113

Changes proposed

  • [✅] My code follows the code style of this project.
  • My change requires changes to the documentation.
  • [✅ ] I have updated the documentation accordingly.
  • [✅] All new and existing tests passed.
  • [✅] This PR does not contain plagiarized content.
  • [✅] The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2023-10-04 at 7 09 08 PM

Note to reviewers

I made changes in app/batches/layout.tsx.

Previously:

<MainNav items={docsConfig.mainNav}>
    <DocsSidebarNav items={docsConfig.sidebarNav} />
</MainNav>

Now:

<MainNav items={navConfig}>
    <DocsSidebarNav items={docsConfig.sidebarNav} />
</MainNav>

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 2:27pm

@Vishal-raj-1 Vishal-raj-1 merged commit 2461f71 into FrontendFreaks:master Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs menu option only seen on home page
2 participants