Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated loop content for DSA folder #105

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Updated loop content for DSA folder #105

merged 1 commit into from
Oct 4, 2023

Conversation

nsundriyal62
Copy link
Contributor

##Update the Content of Loops Page of DSA in JS
Closes #99

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 3:14pm

@nsundriyal62
Copy link
Contributor Author

@sujitmemane sir

check it out please
then i will going to solve other problems

@sujitmemane
Copy link
Member

@sujitmemane sir

check it out please then i will going to solve other problems
Please also attach screenshot , We are facing hosting issues here

@nsundriyal62
Copy link
Contributor Author

ok sir

@nsundriyal62
Copy link
Contributor Author

screencapture-localhost-3000-batch-dsa-loops-2023-10-02-21_53_09
screencapture-localhost-3000-batch-dsa-loops-2023-10-02-21_54_00

Vishal-raj-1
Vishal-raj-1 requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@Vishal-raj-1 Vishal-raj-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to copy the source code and practice questions from DSA In JavaScript Repo

@nsundriyal62
Copy link
Contributor Author

should i copy entire source code in assignment section or
do you want anything else?
i am little bit in confusion

sir can you please explain a bit more
i just new to these github and all

@Vishal-raj-1 Vishal-raj-1 merged commit 4023ce3 into FrontendFreaks:master Oct 4, 2023
2 checks passed
@nsundriyal62 nsundriyal62 deleted the loop_content_dsa branch October 5, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vishal-raj-1 Vishal-raj-1 Vishal-raj-1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Content of Loops Page of DSA in JS
3 participants
@nsundriyal62 @sujitmemane @Vishal-raj-1