Fix provisioning script certificate parsing #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The STM board returns a slightly different format (ending with 'A=') when generating the public key. This cannot be parsed by Python's cryptography library which instead expects the '==' ending. Issue - FreeRTOS#94
AniruddhaKanhere
approved these changes
Feb 22, 2024
paulbartell
reviewed
Feb 22, 2024
|
I'd prefer to address the spelling mistakes in a separate CR as to not overload this rather simple change. |
paulbartell
approved these changes
Feb 22, 2024
|
This change doesn't effect spelling failures nor links. These can be addressed in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The STM board returns a slightly different format
(ending with 'A=') when generating the public key. This cannot be parsed by Python's cryptography library which instead expects the '==' ending.
Thanks @paulbartell and @AniruddhaKanhere for the help
Test Steps
Snagged an STM32u5 board and followed getting started guide. Before I was receiving....
After the changes provisioning is successful. I am also seeing env_sensor_data and motion_sensor_data published to my account.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.