Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Project fails to link when compiled as C++ #65

Closed
txf- opened this issue Jan 15, 2024 · 2 comments · Fixed by #66
Closed

[BUG] Project fails to link when compiled as C++ #65

txf- opened this issue Jan 15, 2024 · 2 comments · Fixed by #66
Labels
bug Something isn't working

Comments

@txf-
Copy link

txf- commented Jan 15, 2024

Describe the bug
app_wifi, core_mqtt_agent_manager and subscription_manager are not linking in a C++ project.

Expected behavior
The headers files are missing the indication to treat these as C linkage.

#ifdef __cplusplus
extern "C" {
#endif

/*FUNCTION PROTOTYPES*/

#ifdef __cplusplus
}
#endif

I don't know if this is done on purpose or it is a bug.

@ericbj29
Copy link
Contributor

Hi @txf-, thanks for bringing this to our attention. This is a bug. If you are willing, we would appreciate it if you could open a PR fixing the issue. If not, I'm happy to do so as well. Thanks again!

@ericbj29 ericbj29 added the bug Something isn't working label Jan 15, 2024
@ericbj29
Copy link
Contributor

If you do decide to raise a PR, please double check the other header files. It seems core_mqtt_agent_manager_events.h needs to be updated as well.

@ericbj29 ericbj29 linked a pull request Jan 16, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants