Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix speech recognition application #74

Merged

Conversation

AhmedIsmail02
Copy link
Contributor

@AhmedIsmail02 AhmedIsmail02 commented May 23, 2024

Description

Changes done as part of this PR:

  • The block time for the DSP task in speech-recognition application is increased from 120 ms to 140 ms as it seems to be overusing the CPU which result in incorrect inference with Software inference engine configuration.

  • pytests inside the nightly jobs sw-vsi-config-test, and gnu-toolchain-test should be run as part of the script section of these jobs as running the tests in the after_script section of these jobs won't have an influence on the exit code of the pipeline which might lead to false negative misleading CI results.

  • Tick rates are modified for all platforms to fix speech-recognition application with software inference issues related to incorrect inferred sentence.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tick rates are modified for all platforms to
fix speech-recognition application with software
inference issues related to incorrect inferred
sentence.

Signed-off-by: Ahmed Ismail <[email protected]>
The block time for the DSP task in speech-recognition application
is increased from `120` ms to `140` ms as it seems to be overusing
the CPU which result in incorrect inference with Software inference
engine configuration.

Signed-off-by: Ahmed Ismail <[email protected]>
pytests inside the nightly jobs `sw-vsi-config-test`,
and `gnu-toolchain-test` should be run as part of the
`script` section of these jobs as running the tests
in the `after_script` section of these jobs won't
have an influence on the exit code of the pipeline
which might lead to false negative misleading CI results.

Signed-off-by: Ahmed Ismail <[email protected]>
It is always better to have a single return/exit
from a function/test in which it would be easier for
users to understand.

Signed-off-by: Ahmed Ismail <[email protected]>
@AhmedIsmail02 AhmedIsmail02 requested a review from a team as a code owner May 23, 2024 09:10
@urutva urutva merged commit be29b1b into FreeRTOS:main May 23, 2024
15 checks passed
@amazonKamath amazonKamath self-requested a review May 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants