Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add priority event queues #894

Open
go2sh opened this issue Jun 1, 2023 · 4 comments
Open

[Feature Request] Add priority event queues #894

go2sh opened this issue Jun 1, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@go2sh
Copy link
Contributor

go2sh commented Jun 1, 2023

Is your feature request related to a problem? Please describe.
For certain application it is desirable to have multiple priorities during sending of packets. For example an audio stream might have strict jitter requirements and thus should always be send on time. In conjunction with a network hardware supporting mutiple queues, this provides a powerful tool for time sensitive networking.

Describe the solution you'd like
Have multiple worker queues for tx and rx events to allow packets to overtake each other. All other events would be processed in the highst priority queue.

Describe alternatives you've considered
None

This feature could be implemented as an opt in. Only two functions access the network queue currently. These could be expanded to support priorities. The priority could set through setsockopt (SO_PRIORITY and/or IP_TOS) like in linux/posix. The user could create a map between the priority/TOS and queues and also between queues/priority and hw queues.

I have a working prototype.

@shubnil
Copy link
Member

shubnil commented Jun 5, 2023

Hi Christoph,

Thanks for adding this feature request.
I agree that this will be a useful addition for network hardware supporting multiple FIFOs.

You also mentioned that you have a working prototype. It will be good if you can share the changes as a PR and we will be more than happy to work together for review and fine-tuning and merging the changes.

@shubnil shubnil self-assigned this Jun 5, 2023
@shubnil shubnil added enhancement New feature or request help wanted Extra attention is needed labels Jun 6, 2023
@shubnil
Copy link
Member

shubnil commented Jun 12, 2023

Hi @go2sh,
Gentle Reminder.

@go2sh go2sh mentioned this issue Jun 15, 2023
5 tasks
@go2sh
Copy link
Contributor Author

go2sh commented Jun 15, 2023

Here you go @shubnil . Happy to see your comments coming in :)

@shubnil
Copy link
Member

shubnil commented Jun 17, 2023

Thanks a lot, Christoph. This is really helpful.
We have started reviewing the change and will discuss internally more on the design and synch up with you as well more on the design part.
Please note that the actual merge might happen only in August. We have an important GA release coming up and we will be freezing the branch in a week. However, we will make sure that we merge the change as soon as the release tagging is done.
Thanks for being patient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants