Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit install instructions may be wrong #64

Open
WandererFan opened this issue Aug 31, 2023 · 3 comments
Open

Pre-commit install instructions may be wrong #64

WandererFan opened this issue Aug 31, 2023 · 3 comments

Comments

@WandererFan
Copy link
Contributor

On Linux Mint 20.3, I could not locate pre-commit using Synaptic or command "apt install pre-commit".

I was able to install something called pre-commit using "pip install pre-commit" and install it in Source/FreeCAD with "pre-commit install".

Not sure if the instructions should be changed or if I've installed the wrong thing.

@wwmayer
Copy link

wwmayer commented Aug 31, 2023

Since Ubuntu 22.04 there exists a .deb package: https://packages.ubuntu.com/search?keywords=pre-commit&searchon=names&suite=jammy&section=all
For older versions the package doesn't exist yet. So, maybe your Mint version is too old.

@WandererFan
Copy link
Contributor Author

WandererFan commented Aug 31, 2023 via email

@chennes
Copy link
Member

chennes commented Oct 15, 2023

@WandererFan I've expanded on those instructions since you posted this Issue -- is the current description adequate?
https://github.com/FreeCAD/DevelopersHandbook/blob/master/gettingstarted/index.md#setting-up-for-development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants