Create one Type object per type reference

[oxisto]

Fixes #1768

Benchmark Results

Based on nova (without tests and without CDG/PDG)

Before:

Metric	Value
Number of files translated	654
TranslationManager: Executing Language Frontend	67874 ms
PythonAddDeclarationsPass: Executing Pass	2788 ms
ImportResolver: Executing Pass	14048 ms
TypeResolver: Executing Pass	1810 ms
TypeHierarchyResolver: Executing Pass	781 ms
ResolveCallExpressionAmbiguityPass: Executing Pass	4605 ms
EvaluationOrderGraphPass: Executing Pass	1289 ms
SymbolResolver: Executing Pass	98916 ms
DFGPass: Executing Pass	1663 ms
ControlFlowSensitiveDFGPass: Executing Pass	15150 ms
DynamicInvokeResolver: Executing Pass	450 ms
FilenameMapper: Executing Pass	409 ms
TranslationManager: Translation into full graph	209793 ms

After:

Metric	Value
Number of files translated	654
TranslationManager: Executing Language Frontend	82194 ms
PythonAddDeclarationsPass: Executing Pass	2967 ms
ImportResolver: Executing Pass	14717 ms
TypeResolver: Executing Pass	3225 ms
TypeHierarchyResolver: Executing Pass	299 ms
ResolveCallExpressionAmbiguityPass: Executing Pass	3410 ms
EvaluationOrderGraphPass: Executing Pass	1564 ms
SymbolResolver: Executing Pass	24892 ms
DFGPass: Executing Pass	1713 ms
ControlFlowSensitiveDFGPass: Executing Pass	15246 ms
DynamicInvokeResolver: Executing Pass	523 ms
FilenameMapper: Executing Pass	647 ms
TranslationManager: Translation into full graph	151411 ms

[codecov]

Codecov Report

Attention: Patch coverage is 76.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 76.36%. Comparing base (897955d) to head (af6be91).

Files with missing lines	Patch %	Lines
...aisec/cpg/passes/inference/DFGFunctionSummaries.kt	69.04%	5 Missing and 8 partials ⚠️
...s/kotlin/de/fraunhofer/aisec/cpg/test/TestUtils.kt	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
...main/kotlin/de/fraunhofer/aisec/cpg/TypeManager.kt	83.33% <100.00%> (+0.47%)	⬆️
...otlin/de/fraunhofer/aisec/cpg/graph/NodeBuilder.kt	72.32% <ø> (ø)
...otlin/de/fraunhofer/aisec/cpg/graph/TypeBuilder.kt	57.50% <100.00%> (-7.21%)	⬇️
...ec/cpg/passes/JavaExternalTypeHierarchyResolver.kt	86.66% <100.00%> (+7.87%)	⬆️
...s/kotlin/de/fraunhofer/aisec/cpg/test/TestUtils.kt	71.27% <50.00%> (+0.75%)	⬆️
...aisec/cpg/passes/inference/DFGFunctionSummaries.kt	74.35% <69.04%> (+5.64%)	⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[konradweiss]

I did not encounter any specific issues, however I would like to get the test coverage up if possible with meaningful tests. We should also look into how these changes impact performance

[oxisto]

I did not encounter any specific issues, however I would like to get the test coverage up if possible with meaningful tests. We should also look into how these changes impact performance

The missing coverage is mostly due to the low coverage in the DFG function summaries, which I needed to change because of a rename and this drags into bad patch coverage :(

[oxisto]

I did not encounter any specific issues, however I would like to get the test coverage up if possible with meaningful tests. We should also look into how these changes impact performance

It's faster. 150s vs 200s on the nova benchmark