Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically downloads the latest translation packages/Automated Resource Kit Compression Workflow #25

Open
gengyoubo opened this issue Nov 24, 2024 · 11 comments

Comments

@gengyoubo
Copy link

I was browsing through the modules and came up with a thought... if you automatically download the latest translation resource packs you don't have to put the lang files in them over and over again to be able to translate them properly? Then we can write the lang file in the resource pack, can't we?

@gengyoubo gengyoubo mentioned this issue Nov 24, 2024
@Foxyas
Copy link
Owner

Foxyas commented Nov 24, 2024

I was browsing through the modules and came up with a thought... if you automatically download the latest translation resource packs you don't have to put the lang files in them over and over again to be able to translate them properly? Then we can write the lang file in the resource pack, can't we?

Yet ever time that the Build task is executaded the resources is reset due mcreator so i have a python script in my local workspace that copy the lang files of other folder and paste in the build/resources

@gengyoubo
Copy link
Author

If you read the code I submitted you'll know I'm using SubscribeEvent, so there's no need to register it manually.

@gengyoubo
Copy link
Author

Or do you mean that the automatically downloaded translation packages also disappear?

@Foxyas
Copy link
Owner

Foxyas commented Nov 24, 2024

Or do you mean that the automatically downloaded translation packages also disappear?

Any File in Resorces/assets/lang will be overrite

@gengyoubo
Copy link
Author

That's not what I'm talking about, it's under run/resources.

@Foxyas
Copy link
Owner

Foxyas commented Nov 24, 2024

That's not what I'm talking about, it's under run/resources.

What i mean is that The files in run/resources/assets/lang is removed and overite and due that if i 0ate the langs in there the files will just be removed -_-

@gengyoubo
Copy link
Author

In my setup, the translation packs start downloading after the module is initialized, so it makes sense that they wouldn't be completely deleted as a problem.

@gengyoubo
Copy link
Author

So you don't have to put the translation package into resources.

@gengyoubo gengyoubo changed the title Automatically downloads the latest translation packages Automatically downloads the latest translation packages/Automated Resource Kit Compression Workflow Nov 25, 2024
@gengyoubo
Copy link
Author

I use github's workflow to be able to zip a folder.

@gengyoubo
Copy link
Author

I was browsing through the modules and came up with a thought... if you automatically download the latest translation resource packs you don't have to put the lang files in them over and over again to be able to translate them properly? Then we can write the lang file in the resource pack, can't we?

Yet ever time that the Build task is executaded the resources is reset due mcreator so i have a python script in my local workspace that copy the lang files of other folder and paste in the build/resources

I use a github workflow that allows me to submit a translation file while packaging it into a resource package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants