Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Audio source" settings - Clearer names or Add documentation for that #16

Open
5 tasks done
inson1 opened this issue Jan 3, 2024 · 7 comments
Open
5 tasks done
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@inson1
Copy link

inson1 commented Jan 3, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
I'm also quite confused by the options for "Audio source" in the app settings.
For example, what does "Android default" mean, and why isn't it the default option?

Could this setting be made clearer or add information about what each option means and how one would choose an audio source?

Describe the solution you'd like
title - first would be better

Describe alternatives you've considered
title

@inson1 inson1 added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 3, 2024
@inson1
Copy link
Author

inson1 commented Jan 3, 2024

@Aga-C Aga-C added documentation Improvements or additions to documentation and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 3, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 3, 2024

In Readme nearly nobody will find it. I think the best would be a short description under each radio button. Alternatively, a new entry in FAQ (in the app).

@tanyabouman
Copy link

tanyabouman commented Jan 10, 2024

I think the audio sources in the app correspond to some of the MediaRecorder.AudioSource options from Android.

fun getAudioSourceText(audio_source: Int) = context.getString(
when (audio_source) {
MediaRecorder.AudioSource.DEFAULT -> R.string.audio_source_default
MediaRecorder.AudioSource.MIC -> R.string.audio_source_microphone
MediaRecorder.AudioSource.VOICE_RECOGNITION -> R.string.audio_source_voice_recognition
MediaRecorder.AudioSource.VOICE_COMMUNICATION -> R.string.audio_source_voice_communication
MediaRecorder.AudioSource.UNPROCESSED -> R.string.audio_source_unprocessed
MediaRecorder.AudioSource.VOICE_PERFORMANCE -> R.string.audio_source_voice_performance
else -> R.string.audio_source_camcorder

@Aga-C Aga-C added the enhancement New feature or request label Feb 18, 2024
@smutax
Copy link

smutax commented Feb 25, 2024

Hi there. Would choosing any of the aforementioned audio sources allow recording of two-way voice or Voip communication? Like "call recorder". Thanks.

@tanyabouman
Copy link

Hi there. Would choosing any of the aforementioned audio sources allow recording of two-way voice or Voip communication? Like "call recorder". Thanks.

I don't think you will be able to record calls because VOICE_CALL is an audio source option, but there are some options from the Android API documentation:

  • VOICE_COMMUNICATION Microphone audio source tuned for voice communications such as VoIP. It will for instance take advantage of echo cancellation or automatic gain control if available.

  • VOICE_CALL Voice call uplink + downlink audio source
    Capturing from VOICE_CALL source requires the Manifest.permission.CAPTURE_AUDIO_OUTPUT permission. This permission is reserved for use by system components and is not available to third-party applications.

@smutax
Copy link

smutax commented May 9, 2024

Hi there. Would choosing any of the aforementioned audio sources allow recording of two-way voice or Voip communication? Like "call recorder". Thanks.

I don't think you will be able to record calls because VOICE_CALL is an audio source option, but there are some options from the Android API documentation:

  • VOICE_COMMUNICATION Microphone audio source tuned for voice communications such as VoIP. It will for instance take advantage of echo cancellation or automatic gain control if available.
  • VOICE_CALL Voice call uplink + downlink audio source
    Capturing from VOICE_CALL source requires the Manifest.permission.CAPTURE_AUDIO_OUTPUT permission. This permission is reserved for use by system components and is not available to third-party applications.

Thanks for clarifying. I don't suppose you know, or if it's at all relevant. What Android API feature music recognition applications such as Shazam take advantage of, as they allow recognition of sound(music) internally , from another application, hence my assumption that they can capture audio output? Sorry if above is confusing.

@tanyabouman
Copy link

Thanks for clarifying. I don't suppose you know, or if it's at all relevant. What Android API feature music recognition applications such as Shazam take advantage of, as they allow recognition of sound(music) internally , from another application, hence my assumption that they can capture audio output? Sorry if above is confusing.

I don't know anything about the internals of Shazam, but I'd guess that Capture audio playback is probably similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants