Don't hide hang up button when showing dialpad (#9)

[Aga-C]

Closes #9

qemu-system-x86_64_DCXKPfPXX3.mp4

[naveensingh]

@Aga-C The animation doesn't look okay but I don't have any ideas at the moment. I'll think about a better way to do it or you can try again if you want :)

[Aga-C]

What exactly could be done better?

[inson1]

I think it looks good. Even if there could be better way, this is better than nothing, so If some idea doesnt come, just merge it before next release, please

@Aga-C But what about bigger space between, the button and dialpad? just little bit?

[Aga-C]

@inson1 It's the same margin as in dialpad (the one before calling).

[inson1]

ok (that could be bigger but that isnt part of this PR)

[naveensingh]

Based on your recording, during the dialpad animation, the hangup button is below the semi-transparent dialpad and that looks like a glitch instead of an animation.

Check this old Google Phone APK for inspiration.

Without redesigning the UI, we can do one of these:

• Elevate the hangup button such that the dialpad appears behind it but in front of the other call UI buttons. In this case, the hangup button should always have some android:elevation set.
• Hide the hangup button using shrink animation as it is currently -> Show the dialpad -> Show the hangup button using scale animation.

In any case, we should increase the dialpad bottom padding slightly so there's more padding between the hangup button and the 0 button on the dialpad.

[naveensingh]

Even if there could be better way, this is better than nothing, so If some idea doesnt come, just merge it before next release

Something is always better than nothing, I absolutely agree with that. But in general and regarding any current or future contributions, I'll never merge a PR if I think the problem could have been solved in a better way. That is to enforce quality contributions and for my own peace of mind :)

[Aga-C]

I've added some margin to the bottom of the dialpad and went with the first option of changing the animation (added elevation).

[naveensingh]

Just made some UI changes to enable the dialpad elevation, thanks 👍