Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed showing note picker before unlocking the app (#46) #47

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fixed showing note picker before unlocking the app (#46) #47

merged 1 commit into from
Jul 18, 2024

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented Jun 13, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Moved condition whether to show note picker after the check if the app is password protected.
  • Added similar condition after unlocking the app.

Before/After Screenshots/Screen Record

  • Before:
qemu-system-x86_64_DSFz9Y9pTr.mp4
  • After:
qemu-system-x86_64_tIqz2OsCKc.mp4

Fixes the following issue(s)

Acknowledgement

@naveensingh naveensingh merged commit 95f0677 into FossifyOrg:master Jul 18, 2024
1 check passed
@naveensingh
Copy link
Member

Thanks :)

@Aga-C Aga-C deleted the show-picker-after-unlock branch July 18, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content of Notes App should not become visible until the app is unlocked
2 participants
@Aga-C @naveensingh