-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Longer build times on FontAwesome v6 #145
Comments
@saransh-malik we added more icons to v6 but there does seem to be something else going on here. We haven't solved it yet but we'll add it to the list to look at. |
@robmadole Thanks a lot :) |
Hello. When you'll set a milestone for this issue? |
We are importing everything and Metro's minification step is taking a lot of time for us. So we use a patch to skip it for Font Awesome FortAwesome/Font-Awesome#19272 (comment) |
@femmon Oh well will try this out. |
@robmadole excluding font awesome from minify actually brings back the original build times. So the issue here is too many new icons slowing the minification or anything else? |
Describe the bug
So if I update my fontawesome libraries to v6, the build times for iOS and Android shoot up by a good amount. I reverted back and was able to solve the issue, so something is definitely causing troubles with v6 only.
There is also a open issue on fontawesome library but since its a react native specific issue, thought of opening it up here. I tried all ways of importing icons and even then the build times didn't change.
Expected behavior
Build times should remain same
The text was updated successfully, but these errors were encountered: