-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read aragog output files and make interior plots #239
Conversation
Encountered a slightly odd issue with the Ruff linting. Running |
Hi @timlichtenberg - could you review this please? If you want to test it, you will need to use my aragog branch: https://github.com/ExPlanetology/aragog/tree/hn/writefiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! My only overall worry is to retain capabilities for SPIDER, once Aragog is fully integrated we have to do tests to maintain this.
I agree. It's difficult not knowing if anything has broken at the moment, other than just by running the code and seeing if it looks fine. However, with this merged we should now be able to directly tackle #237. Thanks for the review! |
Calls the
Output.write_at_time()
function in Aragog, which will write a NetCDF file at each PROTEUS iteration - this means we will have 1 interior and 1 atmosphere NetCDF file at each step. Generalised the manner in which these data are accessed between SPIDER and Aragog, so we don't have duplicated plotting code. Added functionality to read and plot Aragog model results when coupled to PROTEUS. This will complete one of the tasks in #236Requires the corresponding Aragog branches to be merged first.
Bump Mors version - support for Python 3.13