From 5901bea70aa74bdefd07018b0805397adbf52533 Mon Sep 17 00:00:00 2001 From: Nathan Kluth Date: Wed, 18 Dec 2024 11:55:35 -0700 Subject: [PATCH 1/5] set engines node version --- package.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 057de6152..121eea886 100644 --- a/package.json +++ b/package.json @@ -460,6 +460,9 @@ "dependencies": [ "build:lib:esm" ] + }, + "engines": { + "node": ">=18.0.0" } } -} +} \ No newline at end of file From f0f09c5c55ef0f246e5c4a225db18146ff3c54e8 Mon Sep 17 00:00:00 2001 From: Nathan Kluth Date: Wed, 18 Dec 2024 12:19:54 -0700 Subject: [PATCH 2/5] prebuild to check node version --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 121eea886..eedd5ddf4 100644 --- a/package.json +++ b/package.json @@ -138,6 +138,7 @@ "clean:cache:lint": "rimraf .eslintcache \"{demo,packages}/*/.eslintcache\"", "clean:cache:wireit": "rimraf .wireit \"{demo,packages}/*/.wireit\"", "clean:cache:modules": "rimraf node_modules/.cache \"{demo,packages}/*/node_modules/.cache\"", + "prebuild": "node -v", "build": "wireit", "build:lib:esm": "wireit", "build:typescript": "wireit", From a071c72ea499cc228b926daa7ce5dffaf80e987a Mon Sep 17 00:00:00 2001 From: Nathan Kluth Date: Wed, 18 Dec 2024 12:23:09 -0700 Subject: [PATCH 3/5] prebuild didn't run --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index eedd5ddf4..0e2e4fb31 100644 --- a/package.json +++ b/package.json @@ -126,6 +126,7 @@ "not dead" ], "scripts": { + "version-check": "node -v", "version": "pnpm changeset version && pnpm install --no-frozen-lockfile", "publish": "nps git:tag && pnpm changeset publish --no-git-tag", "changeset": "changeset", @@ -138,7 +139,6 @@ "clean:cache:lint": "rimraf .eslintcache \"{demo,packages}/*/.eslintcache\"", "clean:cache:wireit": "rimraf .wireit \"{demo,packages}/*/.wireit\"", "clean:cache:modules": "rimraf node_modules/.cache \"{demo,packages}/*/node_modules/.cache\"", - "prebuild": "node -v", "build": "wireit", "build:lib:esm": "wireit", "build:typescript": "wireit", @@ -184,6 +184,7 @@ }, "build": { "dependencies": [ + "version-check", "./packages/victory-native:build", "./packages/victory-vendor:build", "./packages/victory:build", From 1b353de59b6d211134401aef7ef6aa014f7e38a7 Mon Sep 17 00:00:00 2001 From: Nathan Kluth Date: Wed, 8 Jan 2025 09:52:20 -0700 Subject: [PATCH 4/5] sync packages --- package.json | 3 +-- packages/victory-area/package.json | 3 +++ packages/victory-axis/package.json | 3 +++ packages/victory-bar/package.json | 3 +++ packages/victory-box-plot/package.json | 3 +++ packages/victory-brush-container/package.json | 3 +++ packages/victory-brush-line/package.json | 3 +++ packages/victory-candlestick/package.json | 3 +++ packages/victory-canvas/package.json | 3 +++ packages/victory-chart/package.json | 3 +++ packages/victory-core/package.json | 3 +++ packages/victory-create-container/package.json | 3 +++ packages/victory-cursor-container/package.json | 3 +++ packages/victory-errorbar/package.json | 3 +++ packages/victory-group/package.json | 3 +++ packages/victory-histogram/package.json | 3 +++ packages/victory-legend/package.json | 3 +++ packages/victory-line/package.json | 3 +++ packages/victory-pie/package.json | 3 +++ packages/victory-polar-axis/package.json | 3 +++ packages/victory-scatter/package.json | 3 +++ packages/victory-selection-container/package.json | 3 +++ packages/victory-shared-events/package.json | 3 +++ packages/victory-stack/package.json | 3 +++ packages/victory-tooltip/package.json | 3 +++ packages/victory-voronoi-container/package.json | 3 +++ packages/victory-voronoi/package.json | 3 +++ packages/victory-zoom-container/package.json | 3 +++ packages/victory/package.json | 3 +++ scripts/sync-pkgs-wireit-helpers.js | 3 +++ 30 files changed, 88 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 0e2e4fb31..e391fc9c9 100644 --- a/package.json +++ b/package.json @@ -184,7 +184,6 @@ }, "build": { "dependencies": [ - "version-check", "./packages/victory-native:build", "./packages/victory-vendor:build", "./packages/victory:build", @@ -467,4 +466,4 @@ "node": ">=18.0.0" } } -} \ No newline at end of file +} diff --git a/packages/victory-area/package.json b/packages/victory-area/package.json index 620c90634..177ddf905 100644 --- a/packages/victory-area/package.json +++ b/packages/victory-area/package.json @@ -260,5 +260,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-axis/package.json b/packages/victory-axis/package.json index 173dd3671..f0777c053 100644 --- a/packages/victory-axis/package.json +++ b/packages/victory-axis/package.json @@ -245,5 +245,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-bar/package.json b/packages/victory-bar/package.json index 481c621b6..f4452aa6f 100644 --- a/packages/victory-bar/package.json +++ b/packages/victory-bar/package.json @@ -260,5 +260,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-box-plot/package.json b/packages/victory-box-plot/package.json index 40ff16785..d2c2a3316 100644 --- a/packages/victory-box-plot/package.json +++ b/packages/victory-box-plot/package.json @@ -260,5 +260,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-brush-container/package.json b/packages/victory-brush-container/package.json index e7f5ce9c7..bf380dbdb 100644 --- a/packages/victory-brush-container/package.json +++ b/packages/victory-brush-container/package.json @@ -246,5 +246,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-brush-line/package.json b/packages/victory-brush-line/package.json index 46f1295e5..06ed38bb0 100644 --- a/packages/victory-brush-line/package.json +++ b/packages/victory-brush-line/package.json @@ -246,5 +246,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-candlestick/package.json b/packages/victory-candlestick/package.json index 607157de5..9a1140d6a 100644 --- a/packages/victory-candlestick/package.json +++ b/packages/victory-candlestick/package.json @@ -253,5 +253,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-canvas/package.json b/packages/victory-canvas/package.json index 13870e73d..3f42fefbb 100644 --- a/packages/victory-canvas/package.json +++ b/packages/victory-canvas/package.json @@ -255,5 +255,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-chart/package.json b/packages/victory-chart/package.json index a50934058..8624a820c 100644 --- a/packages/victory-chart/package.json +++ b/packages/victory-chart/package.json @@ -276,5 +276,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-core/package.json b/packages/victory-core/package.json index 6609c9af5..f5e454d31 100644 --- a/packages/victory-core/package.json +++ b/packages/victory-core/package.json @@ -244,5 +244,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-create-container/package.json b/packages/victory-create-container/package.json index 2a01101c8..76ea8a103 100644 --- a/packages/victory-create-container/package.json +++ b/packages/victory-create-container/package.json @@ -295,5 +295,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-cursor-container/package.json b/packages/victory-cursor-container/package.json index 1a823b424..e01bdc09d 100644 --- a/packages/victory-cursor-container/package.json +++ b/packages/victory-cursor-container/package.json @@ -245,5 +245,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-errorbar/package.json b/packages/victory-errorbar/package.json index 2f25a7ef7..457759e05 100644 --- a/packages/victory-errorbar/package.json +++ b/packages/victory-errorbar/package.json @@ -248,5 +248,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-group/package.json b/packages/victory-group/package.json index 8f5da3a7b..01297637c 100644 --- a/packages/victory-group/package.json +++ b/packages/victory-group/package.json @@ -263,5 +263,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-histogram/package.json b/packages/victory-histogram/package.json index ea90a1159..6c85bd9dd 100644 --- a/packages/victory-histogram/package.json +++ b/packages/victory-histogram/package.json @@ -264,5 +264,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-legend/package.json b/packages/victory-legend/package.json index bf21dbd52..7d2991bcb 100644 --- a/packages/victory-legend/package.json +++ b/packages/victory-legend/package.json @@ -245,5 +245,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-line/package.json b/packages/victory-line/package.json index 08438aa9f..40bdcc77b 100644 --- a/packages/victory-line/package.json +++ b/packages/victory-line/package.json @@ -260,5 +260,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-pie/package.json b/packages/victory-pie/package.json index f54a3e83a..edd9f2b85 100644 --- a/packages/victory-pie/package.json +++ b/packages/victory-pie/package.json @@ -253,5 +253,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-polar-axis/package.json b/packages/victory-polar-axis/package.json index dd1d1abdc..a96354858 100644 --- a/packages/victory-polar-axis/package.json +++ b/packages/victory-polar-axis/package.json @@ -245,5 +245,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-scatter/package.json b/packages/victory-scatter/package.json index c6e90a9d9..b0aac7e22 100644 --- a/packages/victory-scatter/package.json +++ b/packages/victory-scatter/package.json @@ -245,5 +245,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-selection-container/package.json b/packages/victory-selection-container/package.json index 39ac9c798..8da464990 100644 --- a/packages/victory-selection-container/package.json +++ b/packages/victory-selection-container/package.json @@ -253,5 +253,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-shared-events/package.json b/packages/victory-shared-events/package.json index 7cd350406..663dc8399 100644 --- a/packages/victory-shared-events/package.json +++ b/packages/victory-shared-events/package.json @@ -247,5 +247,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-stack/package.json b/packages/victory-stack/package.json index 23b3581cf..a1050a7c8 100644 --- a/packages/victory-stack/package.json +++ b/packages/victory-stack/package.json @@ -273,5 +273,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-tooltip/package.json b/packages/victory-tooltip/package.json index 2e617d11d..327758414 100644 --- a/packages/victory-tooltip/package.json +++ b/packages/victory-tooltip/package.json @@ -245,5 +245,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-voronoi-container/package.json b/packages/victory-voronoi-container/package.json index 6bdb5c255..4092b137c 100644 --- a/packages/victory-voronoi-container/package.json +++ b/packages/victory-voronoi-container/package.json @@ -257,5 +257,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-voronoi/package.json b/packages/victory-voronoi/package.json index 2ec65ffbd..26486f955 100644 --- a/packages/victory-voronoi/package.json +++ b/packages/victory-voronoi/package.json @@ -242,5 +242,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory-zoom-container/package.json b/packages/victory-zoom-container/package.json index d07f8c38f..fa2f43235 100644 --- a/packages/victory-zoom-container/package.json +++ b/packages/victory-zoom-container/package.json @@ -245,5 +245,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/packages/victory/package.json b/packages/victory/package.json index f6d2137ef..f04d96bd9 100644 --- a/packages/victory/package.json +++ b/packages/victory/package.json @@ -501,5 +501,8 @@ "pnpm-lock.yaml" ] } + }, + "engines": { + "node": ">=18.0.0" } } diff --git a/scripts/sync-pkgs-wireit-helpers.js b/scripts/sync-pkgs-wireit-helpers.js index e49328b8f..aac41c2ea 100644 --- a/scripts/sync-pkgs-wireit-helpers.js +++ b/scripts/sync-pkgs-wireit-helpers.js @@ -42,6 +42,9 @@ function generateWireitConfig(pkg, rootPkg) { "lint:fix": "wireit", "jest": "wireit", }, + "engines": { + "node": ">=18.0.0" + }, "wireit": { "### THESE WIREIT CONFIGS ARE GENERATED ####": {}, "### DO NOT MODIFY THESE MANUALLY ####": {}, From 038cac00668861a749fd901418e68b74487cade4 Mon Sep 17 00:00:00 2001 From: Nathan Kluth Date: Wed, 8 Jan 2025 09:52:53 -0700 Subject: [PATCH 5/5] rm --- package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index e391fc9c9..121eea886 100644 --- a/package.json +++ b/package.json @@ -126,7 +126,6 @@ "not dead" ], "scripts": { - "version-check": "node -v", "version": "pnpm changeset version && pnpm install --no-frozen-lockfile", "publish": "nps git:tag && pnpm changeset publish --no-git-tag", "changeset": "changeset", @@ -466,4 +465,4 @@ "node": ">=18.0.0" } } -} +} \ No newline at end of file