Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery page error #2684

Closed
toropov023 opened this issue Dec 25, 2023 · 5 comments
Closed

Gallery page error #2684

toropov023 opened this issue Dec 25, 2023 · 5 comments

Comments

@toropov023
Copy link
Contributor

Describe the bug
The gallery page is not working.

Victory version
N/A

Code Sandbox link
N/A

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://formidable.com/open-source/victory/gallery/
  2. See error

Expected behavior
No error.

Screenshots
image
image
image

Desktop (please complete the following information):

  • OS: Mac
  • Browser: Chrome
@toropov023
Copy link
Contributor Author

toropov023 commented Dec 25, 2023 •
edited
Loading

I think the issue is here

Should be: const props = {...defaultProps, ..._props}

@toropov023 toropov023 mentioned this issue Dec 25, 2023
Merged
@smilemittal
Copy link

docs are also not working properly
https://formidable.com/open-source/victory/docs/
sidebar missing and search is also not working

@hafizgohar
Copy link

yes docs are working fine too
https://formidable.com/open-source/victory/docs/

@tony
Copy link

tony commented Dec 31, 2023

Related #2686

@KenanYusuf
Copy link
Contributor

Fixed in #2685

Separate PR coming for the sidebar issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tony @toropov023 @KenanYusuf @smilemittal @hafizgohar