Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Align code standards with those in Victory (defaults/configurations/walmart/es6-react) #554

Closed
tptee opened this issue Jan 25, 2016 · 2 comments
Labels

Comments

@tptee
Copy link
Contributor

tptee commented Jan 25, 2016

Victory uses defaults/configurations/walmart/es6-react and we'd like this to become out canonical style for future repos, including the component library under the radium umbrella. As Radium becomes an aggregator, this would be a good time to convert radium-style to match the new ESLint configuration.

@tptee
Copy link
Contributor Author

tptee commented Jan 25, 2016

In https://github.com/FormidableLabs/builder-victory-component/tree/master/config/eslint, there are extra config files for test and coverage that expose some globals to ESLint. It would help to split the npm run-script lint script into separate ones targeted for production, test, coverage, etc. Check out the package.json of https://github.com/FormidableLabs/builder-victory-component for an example (uses Builder).

@kylecesmat
Copy link
Contributor

Closing in favor of #969

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants