Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bullets: use a persistent collection instead of a simple array #130

Open
ForNeVeR opened this issue Jun 16, 2023 · 0 comments
Open

Bullets: use a persistent collection instead of a simple array #130

ForNeVeR opened this issue Jun 16, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed refactoring A code improvement that doesn't lead to change in behavior.

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Jun 16, 2023 •
edited
Loading

Currently, we use an array for GameEngine.Bullets which leads to the bullet array being recreated often.

This could be somewhat improved if we use a persistent collection such as a persistent vector instead.

See TODO[#130] in the code.
@ForNeVeR ForNeVeR added help wanted Extra attention is needed good first issue Good for newcomers refactoring A code improvement that doesn't lead to change in behavior. labels Jun 16, 2023
ForNeVeR added a commit that referenced this issue Jun 16, 2023
@ForNeVeR
(#26, #32, #129, #130, #131) Connect TODOs with the issues
8fd3d2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed refactoring A code improvement that doesn't lead to change in behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ForNeVeR