Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancellation during game loading #103

Open
ForNeVeR opened this issue May 28, 2023 · 0 comments
Open

Cancellation during game loading #103

ForNeVeR opened this issue May 28, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented May 28, 2023 •
edited
Loading

Currently, our loading doesn't support cancellation: any tasks left running after the user presses the cancel button will still be performed and the disposed synchronization context will then throw an error.

We should probably downgrade the exceptions to logger.warn and also pass the cancellation token to the game initialization tasks.

See TODO[#103] in the game code.
@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 28, 2023
ForNeVeR added a commit that referenced this issue May 28, 2023
@ForNeVeR
(#103) Connect a TODO with the issue
e786c9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ForNeVeR